feat(jsonpath): add a real jsonpath parser#1568
Closed
JannikBulow wants to merge 2 commits intoTwiN:masterfrom
Closed
feat(jsonpath): add a real jsonpath parser#1568JannikBulow wants to merge 2 commits intoTwiN:masterfrom
JannikBulow wants to merge 2 commits intoTwiN:masterfrom
Conversation
Library used is https://github.com/oliveagle/jsonpath I made sure to check the output of the library so tests would succeed. This technically means that it's not 100% correct JSONPath output.
I forgot to run this before the first commit.
|
We could really use this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Library used is https://github.com/oliveagle/jsonpath I made sure to check the output of the library so tests would succeed. This technically means that it's not 100% correct JSONPath output.
Summary
I decided to switch out the "half-baked json path implementation that needs some love" with an actual library as I needed a filter selector for my status page. I have done my best to keep the output the same as the older parser so no one will have to update their conditions.
I am not very good at writing tests or documentation so I simply haven't, but all the existing tests passed.
Checklist
README.md, if applicable.