This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Merged
Conversation
|
Yeah, this seems legit. It strikes me as weird/unsupported to be running an inline script while BUNDLE_FROZEN is set, but if we can make it work, why not. :) r+ from me. |
Contributor
Author
|
Thanks! @bundlerbot r=indirect |
ghost
pushed a commit
that referenced
this pull request
Apr 24, 2019
7125: Ignore `frozen` setting in inline mode r=indirect a=deivid-rodriguez Fixes #7114. ### What was the end-user problem that led to this PR? The problem was that the inline mode wouldn't work if `BUNDLE_FROZEN` is set. ### What was your diagnosis of the problem? My diagnosis was that since we're in frozen mode, the current platform doesn't get added to the definition, and thus platform validation fails. ### What is your fix for the problem, implemented in this PR? My fix is to temporary ignore `BUNDLE_FROZEN` for the inline mode. The inline mode can't really be frozen since it has no lock file. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit 
|
re: @indirect
I was the one that submitted the original issue bringing this up. The use case I have is a Rails 4 app but I have a standalone script in the project that is using inline to load a 5.x version of ActiveSupport. After deploy capistrano froze the bundle and the standalone fails without this fix. FYI (e) |
4 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7114.
What was the end-user problem that led to this PR?
The problem was that the inline mode wouldn't work if
BUNDLE_FROZENis set.What was your diagnosis of the problem?
My diagnosis was that since we're in frozen mode, the current platform doesn't get added to the definition, and thus platform validation fails.
What is your fix for the problem, implemented in this PR?
My fix is to temporary ignore
BUNDLE_FROZENfor the inline mode. The inline mode can't really be frozen since it has no lock file.