fix: avoid android.os.strictmode.UnbufferedIoViolation (resubmission of PR #6565)#6822
Merged
davidmotson merged 3 commits intofirebase:mainfrom Apr 15, 2025
gubatron:fix/unbuffered-io-violation-android-14-resubmission
Merged
fix: avoid android.os.strictmode.UnbufferedIoViolation (resubmission of PR #6565)#6822davidmotson merged 3 commits intofirebase:mainfrom gubatron:fix/unbuffered-io-violation-android-14-resubmission
davidmotson merged 3 commits intofirebase:mainfrom
gubatron:fix/unbuffered-io-violation-android-14-resubmission
Conversation
Contributor
Author
|
Original Issue: #6564 |
Contributor
|
Hi, unsure if this is a different repo than your previous PR, but remember to add the same Firebase json secret as before to get these test passing! |
Contributor
Author
|
same repo, will check the settings. Perhaps I have to recreate the whole firebase secret thing again |
mrober
approved these changes
Apr 9, 2025
…redInputStream - Wrap InputStream with BufferedInputStream to ensure buffered I/O and prevent UnbufferedIoViolation in Android 14 (SDK 34). - Use try-with-resources to automatically close streams, improving resource management. - Retain existing functionality for converting InputStream to a UTF-8 string. This change ensures compliance with Android 14's stricter I/O policies.
Contributor
Author
|
rebased and amended commits to be signed. |
gubatron
deleted the
fix/unbuffered-io-violation-android-14-resubmission
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures compliance with Android 14's stricter I/O policies.