fix: race condition in exporter, bodyclose in WS tests, dupl nolint

- Copy exporter before mutating AsYAML to avoid racing on the shared
  registry singleton when parallel tests call Export()
- Close WebSocket dial response body via t.Cleanup in test helper
- Add nolint:dupl to printVerboseEntry (intentional mirror for
  different wire type)

Author: zach-snell

pkg/cli/logs.go

@@ -665,6 +665,8 @@ func printTableEntry(req *requestlog.Entry) {
 }
 
 // printVerboseEntry prints a single log entry in verbose format.
+//
+//nolint:dupl // Intentionally mirrors printVerboseAPIEntry for a different wire type.
 func printVerboseEntry(req *requestlog.Entry) {
 	timestamp := req.Timestamp.Format("2006-01-02 15:04:05")
 	protocol := req.Protocol

pkg/portability/exporter.go

@@ -70,14 +70,18 @@ func Export(collection *config.MockCollection, opts *ExportOptions) (*ExportResu
 		}
 	}
 
-	// Wire caller options into the exporter when explicitly set.
-	// NativeExporter and OpenAPIExporter both honour AsYAML.
+	// Wire caller options into a local copy of the exporter so parallel
+	// callers don't race on the shared registry singleton.
 	if opts.AsYAML != nil {
 		switch e := exporter.(type) {
 		case *NativeExporter:
-			e.AsYAML = *opts.AsYAML
+			local := *e
+			local.AsYAML = *opts.AsYAML
+			exporter = &local
 		case *OpenAPIExporter:
-			e.AsYAML = *opts.AsYAML
+			local := *e
+			local.AsYAML = *opts.AsYAML
+			exporter = &local
 		}
 	}
 

pkg/websocket/handler_e2e_test.go

@@ -18,7 +18,11 @@ import (
 func dialWS(t *testing.T, ts *httptest.Server, path string) (*gorillaWs.Conn, *http.Response, error) {
 	t.Helper()
 	wsURL := "ws" + strings.TrimPrefix(ts.URL, "http") + path
-	return gorillaWs.DefaultDialer.Dial(wsURL, nil)
+	conn, resp, err := gorillaWs.DefaultDialer.Dial(wsURL, nil)
+	if resp != nil && resp.Body != nil {
+		t.Cleanup(func() { _ = resp.Body.Close() })
+	}
+	return conn, resp, err
 }
 
 // setupHandler creates a ConnectionManager, registers the given endpoints,