type performance: 1,300+ lines of overrides for one function #5048
dimitropoulos
started this conversation in
Show and tell
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Which @ngrx/* package(s) are the source of the bug?
signals
Minimal reproduction of the bug/regression with instructions
hi! I'm working on TypeSlayer a TypeScript types performance/analysis tool.
the TLRD; is it helps you find why your typechecking is slow. it's in early access now (more than happy to provide any maintainers an access code, DM me
dimitropouloson discord) and early testers are starting to send me areas they're finding in their codebases that are causing slowdowns. one person used TypeSlayer to find slowness coming from this type, which has 1,300+ lines of overrides (56 of them in total).I'd like to better understand why this type exists, what you're trying to accomplish, and if you're interested in finding a way to better gauge the cost/benefit on the impact on your user's typechecking time.
thoughts?
I've seen similar techniques used in the past (example, example) but never to this extent.
Expected behavior
fewer than 10 overrides, or at least fewer than 56
Versions of NgRx, Angular, Node, affected browser(s) and operating system(s)
n/a - just the types
Other information
No response
I would be willing to submit a PR to fix this issue
Beta Was this translation helpful? Give feedback.
All reactions