Simplify styler_df() signature#1009
Merged
IndrajeetPatil merged 2 commits intor-lib:mainfrom Sep 28, 2022
IndrajeetPatil:rm_warning_1007_followup
Merged
Simplify styler_df() signature#1009IndrajeetPatil merged 2 commits intor-lib:mainfrom IndrajeetPatil:rm_warning_1007_followup
styler_df() signature#1009IndrajeetPatil merged 2 commits intor-lib:mainfrom
IndrajeetPatil:rm_warning_1007_followup
Conversation
This is generating warnings. Follow-up on #1007
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if f0a3a08 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Member
|
What kinds of warning are we seeing here? |
Collaborator
Author
|
Strange. I can't reproduce this anymore. I think the PR is still worth considering, though, for simplifying the wrapper function |
.name_repair argstyler_df() signature
lorenzwalthert
approved these changes
Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is generating warnings.
Follow-up on #1007