Drop {rematch2} dependency#1011
Merged
IndrajeetPatil merged 4 commits intor-lib:mainfrom Sep 28, 2022
IndrajeetPatil:1010_rm_rematch2
Merged
Drop {rematch2} dependency#1011IndrajeetPatil merged 4 commits intor-lib:mainfrom IndrajeetPatil:1010_rm_rematch2
{rematch2} dependency#1011IndrajeetPatil merged 4 commits intor-lib:mainfrom
IndrajeetPatil:1010_rm_rematch2
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
+ Coverage 91.14% 91.20% +0.05%
==========================================
Files 46 46
Lines 2664 2682 +18
==========================================
+ Hits 2428 2446 +18
Misses 236 236
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
Can you relax the failing test a bit? I.e. it does not have to be 5 times faster, 4x is also enough I think. |
Collaborator
|
Yeah, licence I also checked but both are MIT, so should be fine. |
Collaborator
Author
Done. |
krlmlr
approved these changes
Sep 28, 2022
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 5b69525 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1010