Bump minimum needed R version to 4.0#1197
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1197 +/- ##
=======================================
Coverage 92.16% 92.17%
=======================================
Files 46 46
Lines 2654 2657 +3
=======================================
+ Hits 2446 2449 +3
Misses 208 208 ☔ View full report in Codecov by Sentry. |
| object_overwrite_linter = NULL, | ||
| object_usage_linter = NULL, | ||
| todo_comment_linter = NULL, | ||
| extraction_operator_linter = NULL, |
There was a problem hiding this comment.
This linter was removed from lintr recently.
| config: | ||
| - {os: macos-latest, r: 'release'} | ||
|
|
||
| - {os: windows-latest, r: 'devel'} |
There was a problem hiding this comment.
I think we should always be testing on windows-devel.
It's currently failing because of this issue: gagolews/stringi#508
| if (any(pd$token == "equal_assign")) 2L else 3L | ||
| } | ||
|
|
||
| parser_version_find <- function(pd) 3L |
There was a problem hiding this comment.
pd is retained for future use cases.
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if f5744da is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
lorenzwalthert
left a comment
lorenzwalthert
left a comment
There was a problem hiding this comment.
Looks good to me, thanks.
|
You are currently a contributor of the package and you contribute a lot. Thank you for that. I think the amount and quality would qualify you to be an author. Would you be interested? |
|
I would be honored to! Thanks 💕 |
2 participants
Closes #1196