empty curly have no spaces around

[lorenzwalthert]

Towards #1231.

[IndrajeetPatil]

Thanks. This is a good start. Just one case remains to be covered.

[IndrajeetPatil]

We also need to get rid of line-breaks, if present (cf. #1232):

"while (TRUE) { 

}" -> code

styler::style_text(code)
#> while (TRUE) {
#> 
#> }

^{Created on 2024-10-06 with reprex v2.1.1}

[lorenzwalthert]

Right…

[lorenzwalthert]

Ok, but that seems to imply that we always remove the line breaks inside an empy {}, which breaks a bunch of other test cases, see e1455c6... Do you think that's inline with the style guide?

[IndrajeetPatil]

Yes, I think this is what the style guide dictates, and all the new changes look desirable as per the style guide.

[github-actions]

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 9d076fc is merged into main:

• ✔️cache_applying: 156ms -> 158ms [-2.54%, +4.9%]
• ✔️cache_recording: 537ms -> 541ms [-0.66%, +2.38%]
• ✔️without_cache: 1.01s -> 1s [-1.02%, +0.59%]

Further explanation regarding interpretation and methodology can be found in the documentation.

[github-actions]

This is how benchmark results would change (along with a 95% confidence interval in relative change) if e1455c6 is merged into main:

• ✔️cache_applying: 142ms -> 143ms [-2.33%, +2.89%]
• ✔️cache_recording: 504ms -> 506ms [-0.68%, +1.49%]
• ✔️without_cache: 977ms -> 988ms [0%, +2.21%]

Further explanation regarding interpretation and methodology can be found in the documentation.

[lorenzwalthert]

Thanks for the review. 🎉