Make Addin for selection styling respecting line breaks in general#520
Merged
lorenzwalthert merged 1 commit intor-lib:masterfrom Jun 16, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
==========================================
+ Coverage 90.12% 90.18% +0.05%
==========================================
Files 39 39
Lines 1732 1732
==========================================
+ Hits 1561 1562 +1
+ Misses 171 170 -1
Continue to review full report at Codecov.
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the Addin did not support selecting the last line to style as a full line as shown below in the sense that it resulted in a line break removed and resulted in invalid R code.
resulted in
For the last line selected for styling, one had to select a finite

col2value to prevent this.This resulted in the correct styling
This PR removes the constraint of having to select the code as in the second example (i.e. a non-finite
col2value is no longer needed) and closes #519.