Valid styling with cached expression in stylerignore#600
Merged
lorenzwalthert merged 7 commits intor-lib:masterfrom Feb 15, 2020
Merged
Valid styling with cached expression in stylerignore#600lorenzwalthert merged 7 commits intor-lib:masterfrom
lorenzwalthert merged 7 commits intor-lib:masterfrom
Conversation
lorenzwalthert
force-pushed
the
issue-598
branch
from
fb78f34 to
d22a475
Compare
…en calculating spaces and newlines on the shallow parse table, the assumption that we have all tokens in the parse table is not true (anymore, compared to before caching was introduced). We hence cannot remove non-terminals if they are cached expressions to calculate spaces and newliens between tokens, becaues their children are not present anymore.
… the previous fix added more non-terminal but cached tokens to stylerignore, where the parse data is validated and becomes invlid if the comment tokens from the cached expressions are listed as separate tokens. Because expr will be first element with parent 0, the condition simplifies.
lorenzwalthert
force-pushed
the
issue-598
branch
from
d22a475 to
3a81976
Compare
lorenzwalthert
changed the title
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
==========================================
+ Coverage 92.12% 92.12% +<.01%
==========================================
Files 47 47
Lines 2095 2096 +1
==========================================
+ Hits 1930 1931 +1
Misses 165 165
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #598 by adding cached expressions (that are non-terminal by nature) to styler ignore too and drop non-top-level tokens when making the parse table shallow.