Multi-line to carry number of lines instead of boolean #782
Merged
lorenzwalthert merged 8 commits intor-lib:masterfrom Apr 30, 2021
Merged
Multi-line to carry number of lines instead of boolean #782lorenzwalthert merged 8 commits intor-lib:masterfrom
lorenzwalthert merged 8 commits intor-lib:masterfrom
Conversation
cd9070e to
e69e812
Compare
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
==========================================
+ Coverage 90.55% 90.62% +0.07%
==========================================
Files 47 47
Lines 2393 2411 +18
==========================================
+ Hits 2167 2185 +18
Misses 226 226
Continue to review full report at Codecov.
|
e69e812 to
341192c
Compare
This reverts commit 1336499.
341192c to
1774304
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #773.
Here is how the current PR would change benchmark results when merged into master:
With many int replacements:
With them reverted:
Ok, I think 1% speed gain is not worth changing every subsetting from
x[1]tox[1L]. Readability suffers too much.