Skip to content

feat(proof): enhance aggregation request handling with prover isolation#682

Merged
smtmfft merged 1 commit intomainfrom
refine-aggregate
Mar 18, 2026
Merged

feat(proof): enhance aggregation request handling with prover isolation#682
smtmfft merged 1 commit intomainfrom
refine-aggregate

Conversation

@smtmfft
Copy link
Copy Markdown
Contributor

@smtmfft smtmfft commented Mar 18, 2026

  • Updated AggregationRequestKey to include an optional prover address for isolating aggregate proofs per prover.
  • Modified batch_handler and shasta_batch_handler to utilize the new new_with_image_id_and_prover method for creating aggregation keys, allowing for more granular proof management based on the prover.

- Updated `AggregationRequestKey` to include an optional prover address for isolating aggregate proofs per prover.
- Modified `batch_handler` and `shasta_batch_handler` to utilize the new `new_with_image_id_and_prover` method for creating aggregation keys, allowing for more granular proof management based on the prover.
Copilot AI review requested due to automatic review settings March 18, 2026 02:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent aggregation-task key collisions across different provers by extending AggregationRequestKey with an optional prover_address, and wiring that into the v3 batch/Shasta batch aggregation flows.

Changes:

  • Extend AggregationRequestKey with optional prover_address and add a constructor that sets both image_id and prover.
  • Update v3 /batch handler to build aggregation keys with the prover address.
  • Update v3 Shasta batch handler to (a) reuse cached guest inputs and (b) build aggregation keys with the prover address.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
reqpool/src/request.rs Adds prover_address: Option<String> to AggregationRequestKey and a new constructor to include it.
host/src/server/api/v3/proof/shasta_handler.rs Refactors Shasta batch flow to always run the input step first and uses prover-isolated aggregation keys.
host/src/server/api/v3/proof/batch_handler.rs Uses the new prover-isolated aggregation key constructor for batch aggregation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@smtmfft smtmfft added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main with commit 336d037 Mar 18, 2026
16 of 17 checks passed
@smtmfft smtmfft deleted the refine-aggregate branch March 18, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants