feat(proof): enhance aggregation request handling with prover isolation#682
Merged
feat(proof): enhance aggregation request handling with prover isolation#682
Conversation
- Updated `AggregationRequestKey` to include an optional prover address for isolating aggregate proofs per prover. - Modified `batch_handler` and `shasta_batch_handler` to utilize the new `new_with_image_id_and_prover` method for creating aggregation keys, allowing for more granular proof management based on the prover.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent aggregation-task key collisions across different provers by extending AggregationRequestKey with an optional prover_address, and wiring that into the v3 batch/Shasta batch aggregation flows.
Changes:
- Extend
AggregationRequestKeywith optionalprover_addressand add a constructor that sets bothimage_idand prover. - Update v3
/batchhandler to build aggregation keys with the prover address. - Update v3 Shasta batch handler to (a) reuse cached guest inputs and (b) build aggregation keys with the prover address.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| reqpool/src/request.rs | Adds prover_address: Option<String> to AggregationRequestKey and a new constructor to include it. |
| host/src/server/api/v3/proof/shasta_handler.rs | Refactors Shasta batch flow to always run the input step first and uses prover-isolated aggregation keys. |
| host/src/server/api/v3/proof/batch_handler.rs | Uses the new prover-isolated aggregation key constructor for batch aggregation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
johntaiko
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AggregationRequestKeyto include an optional prover address for isolating aggregate proofs per prover.batch_handlerandshasta_batch_handlerto utilize the newnew_with_image_id_and_provermethod for creating aggregation keys, allowing for more granular proof management based on the prover.