Skip to content

Commit 9233d5e

Browse files
authored
fix(element): update type of IFormDialog (alibaba#3360)
1. 经检查下面的函数实现,IFormDialog中forConfirm、forCancel的参数middleware的类型IMiddleware泛型应为Form而不是IFormProps 2. 更正对应的文档,并参照antd/FormDialog优化,使文档中的类型定义更清晰。
1 parent 936cfa0 commit 9233d5e

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

packages/element/docs/guide/form-dialog.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,18 @@ type IFormDialogProps = Omit<DialogProps, 'title'> & {
5151
}
5252

5353
interface IFormDialog {
54-
forOpen(middleware: IMiddleware<IFormProps>): IFormDialog
55-
forConfirm(middleware: IMiddleware<IFormProps>): IFormDialog
56-
forCancel(middleware: IMiddleware<IFormProps>): IFormDialog
54+
forOpen(
55+
middleware: (
56+
props: IFormProps,
57+
next: (props?: IFormProps) => Promise<any>
58+
) => any
59+
): IFormDialog
60+
forConfirm(
61+
middleware: (props: Form, next: (props?: Form) => Promise<any>) => any
62+
): IFormDialog
63+
forCancel(
64+
middleware: (props: Form, next: (props?: Form) => Promise<any>) => any
65+
): IFormDialog
5766
open(props?: IFormProps): Promise<any>
5867
close(): void
5968
}

packages/element/src/form-dialog/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ const getDialogProps = (props: any): IFormDialogProps => {
6565

6666
export interface IFormDialog {
6767
forOpen(middleware: IMiddleware<IFormProps>): IFormDialog
68-
forConfirm(middleware: IMiddleware<IFormProps>): IFormDialog
69-
forCancel(middleware: IMiddleware<IFormProps>): IFormDialog
68+
forConfirm(middleware: IMiddleware<Form>): IFormDialog
69+
forCancel(middleware: IMiddleware<Form>): IFormDialog
7070
open(props?: IFormProps): Promise<any>
7171
close(): void
7272
}

0 commit comments

Comments
 (0)