Merged
Conversation
I'm copying the setup of one of these actions to another repo, and the hardcoding of `ref` surprised me... these should be the same as the defaault behavior. I checked with Barry who originally committed these files, and he didn't remember why... possibly he'd hardcoded them when testing the action and forgot to remove them. So let's pull them out to remove confusion.
honeyankit
approved these changes
Apr 11, 2025
brrygrdn
reviewed
Apr 11, 2025
|
|
||
| - name: Check out code | ||
| uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v4 |
Contributor
There was a problem hiding this comment.
NAB: We should likely prefer to use a pinned SHA version for safety here since this is automerging PRs ( and rely on Dependabot to keep this up to date 😅 )
Member
Author
There was a problem hiding this comment.
actions/checkout has been migrated to immutable actions, so it's now safe to pin directly to a human semver value. 🎉
brrygrdn
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm copying the setup of one of these actions to another repo, and the hardcoding of
refsurprised me... these should be the same as the defaault behavior. I checked with Barry who originally committed these files, and he didn't remember why... possibly he'd hardcoded them when testing the action and forgot to remove them.So let's pull them out to remove confusion.