Skip to content

fix: prerelease generated version strings that could not be compared#72

Merged
FreekVR merged 1 commit intomainfrom
fix/fix-version-comparison-not-working-for-pr-builds
Mar 3, 2025
Merged

fix: prerelease generated version strings that could not be compared#72
FreekVR merged 1 commit intomainfrom
fix/fix-version-comparison-not-working-for-pr-builds

Conversation

@FreekVR
Copy link
Contributor

@FreekVR FreekVR commented Mar 3, 2025

fix an issue where functions like PHP's version_compare would incorrectly compare a PR build to a pre-existing published version.

we now always append the number of "commits since tag" number so that any build is more likely to be able to be correctly compared and return a greater version number than actual older versions

fixes INT-876

… compared

fix an issue where functions like PHP's `version_compare` would incorrectly compare a PR build to a pre-existing published version. 

we now always append the number of "commits since tag" number so that any build is more likely to be able to be correctly compared and return a greater version number than actual older versions
@FreekVR FreekVR requested a review from a team March 3, 2025 15:39
@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.20%. Comparing base (7e595b2) to head (821f1f7).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   15.20%   15.20%           
=======================================
  Files           2        2           
  Lines         125      125           
  Branches       11       11           
=======================================
  Hits           19       19           
  Misses         95       95           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FreekVR FreekVR changed the title fix: prereleas generated version strings that could not be compared fix: prerelease generated version strings that could not be compared Mar 3, 2025
@FreekVR FreekVR merged commit 17371e2 into main Mar 3, 2025
6 checks passed
@FreekVR FreekVR deleted the fix/fix-version-comparison-not-working-for-pr-builds branch March 3, 2025 15:48
myparcel-bot bot added a commit that referenced this pull request Mar 3, 2025
## [4.44.3](v4.44.2...v4.44.3) (2025-03-03)

### 🐛 Bug Fixes

* prerelease generated version strings that could not be compared ([#72](#72)) ([17371e2](17371e2))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Mar 3, 2025

🎉 This issue has been resolved in version 4.44.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myparcel-bot myparcel-bot bot added the released label Mar 3, 2025
myparcel-bot bot added a commit that referenced this pull request Feb 6, 2026
## [5.1.1](v5.1.0...v5.1.1) (2026-02-06)

### 🐛 Bug Fixes

* **deps:** bump actions/cache from 4 to 5 ([#89](#89)) ([22da9c3](22da9c3)), closes [actions/cache#1630](actions/cache#1630) [actions/cache#1684](actions/cache#1684) [actions/cache#1642](actions/cache#1642) [actions/cache#1655](actions/cache#1655) [actions/cache#1642](actions/cache#1642) [actions/cache#1620](actions/cache#1620) [actions/cache#1634](actions/cache#1634) [actions/cache#1636](actions/cache#1636) [actions/cache#1620](actions/cache#1620) [actions/cache#1577](actions/cache#1577) [actions/cache#1577](actions/cache#1577) [#1474](https://github.com/myparcelnl/actions/issues/1474) [#1475](https://github.com/myparcelnl/actions/issues/1475) [#1684](https://github.com/myparcelnl/actions/issues/1684) [#1630](https://github.com/myparcelnl/actions/issues/1630)
* **deps:** bump actions/checkout from 5 to 6 ([#88](#88)) ([7a79c37](7a79c37)), closes [actions/checkout#2248](actions/checkout#2248) [actions/checkout#2286](actions/checkout#2286) [actions/checkout#2298](actions/checkout#2298) [actions/checkout#2311](actions/checkout#2311) [actions/checkout#2301](actions/checkout#2301) [actions/checkout#2286](actions/checkout#2286) [actions/checkout#2248](actions/checkout#2248) [actions/checkout#2301](actions/checkout#2301) [actions/checkout#2226](actions/checkout#2226) [actions/checkout#2305](actions/checkout#2305) [actions/checkout#1971](actions/checkout#1971) [actions/checkout#1977](actions/checkout#1977) [actions/checkout#2043](actions/checkout#2043) [actions/checkout#2044](actions/checkout#2044) [actions/checkout#2194](actions/checkout#2194) [actions/checkout#2224](actions/checkout#2224) [actions/checkout#2236](actions/checkout#2236) [actions/checkout#1941](actions/checkout#1941) [actions/checkout#1946](actions/checkout#1946) [actions/checkout#1924](actions/checkout#1924) [actions/checkout#1180](actions/checkout#1180) [actions/checkout#1777](actions/checkout#1777) [actions/checkout#1872](actions/checkout#1872) [actions/checkout#1739](actions/checkout#1739) [actions/checkout#1697](actions/checkout#1697) [actions/checkout#1774](actions/checkout#1774) [actions/checkout#1776](actions/checkout#1776) [actions/checkout#1732](actions/checkout#1732) [actions/checkout#1703](actions/checkout#1703) [actions/checkout#1694](actions/checkout#1694) [actions/checkout#1696](actions/checkout#1696) [actions/checkout#1695](actions/checkout#1695) [#2311](https://github.com/myparcelnl/actions/issues/2311) [#2298](https://github.com/myparcelnl/actions/issues/2298) [#2286](https://github.com/myparcelnl/actions/issues/2286) [#2248](https://github.com/myparcelnl/actions/issues/2248)
* **deps:** bump myparcelnl/actions from 4 to 5 ([#84](#84)) ([0370671](0370671)), closes [#80](#80) [#80](#80) [#81](#81) [actions/checkout#2226](actions/checkout#2226) [actions/checkout#2238](actions/checkout#2238) [actions/checkout#1971](actions/checkout#1971) [actions/checkout#1977](actions/checkout#1977) [actions/checkout#2043](actions/checkout#2043) [actions/checkout#2044](actions/checkout#2044) [actions/checkout#2194](actions/checkout#2194) [actions/checkout#2224](actions/checkout#2224) [actions/checkout#2236](actions/checkout#2236) [actions/checkout#2237](actions/checkout#2237) [actions/checkout#1971](actions/checkout#1971) [actions/checkout#1977](actions/checkout#1977) [actions/checkout#2043](actions/checkout#2043) [actions/checkout#2194](actions/checkout#2194) [actions/checkout#2236](actions/checkout#2236) [actions/checkout#1941](actions/checkout#1941) [actions/checkout#1946](actions/checkout#1946) [actions/checkout#1924](actions/checkout#1924) [actions/checkout#1919](actions/checkout#1919) [actions/checkout#2226](actions/checkout#2226) [actions/checkout#1971](actions/checkout#1971) [actions/checkout#1977](actions/checkout#1977) [actions/checkout#2043](actions/checkout#2043) [actions/checkout#2044](actions/checkout#2044) [actions/checkout#2194](actions/checkout#2194) [actions/checkout#2224](actions/checkout#2224) [actions/checkout#2236](actions/checkout#2236) [actions/checkout#1941](actions/checkout#1941) [actions/checkout#1946](actions/checkout#1946) [actions/checkout#1924](actions/checkout#1924) [actions/checkout#1180](actions/checkout#1180) [actions/checkout#1777](actions/checkout#1777) [actions/checkout#1872](actions/checkout#1872) [actions/checkout#1739](actions/checkout#1739) [actions/checkout#1697](actions/checkout#1697) [actions/checkout#1774](actions/checkout#1774) [actions/checkout#1776](actions/checkout#1776) [actions/checkout#1732](actions/checkout#1732) [actions/checkout#1703](actions/checkout#1703) [actions/checkout#1694](actions/checkout#1694) [actions/checkout#1696](actions/checkout#1696) [actions/checkout#1695](actions/checkout#1695) [actions/checkout#1707](actions/checkout#1707) [actions/checkout#1692](actions/checkout#1692) [actions/checkout#1688](actions/checkout#1688) [actions/checkout#1693](actions/checkout#1693) [actions/checkout#1643](actions/checkout#1643) [#2238](https://github.com/myparcelnl/actions/issues/2238) [#2226](https://github.com/myparcelnl/actions/issues/2226) [#74](#74) [#72](#72) [#72](#72) [#82](#82) [#81](#81) [#76](#76) [#80](#80)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants