[BrowserKit][HttpClient] Update the value of some user agents to comply with the RFC 9110 specification#50053
Merged
nicolas-grekas merged 1 commit intosymfony:6.3from Apr 18, 2023
Merged
Conversation
javiereguiluz
changed the title
carsonbot
changed the title
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
thanks, here are some minor comments
nicolas-grekas
approved these changes
Apr 18, 2023
…ly with the RFC 9110 specification
nicolas-grekas
force-pushed
the
fix_50052
branch
from
99903ec to
722bd99
Compare
Member
|
Thank you @javiereguiluz. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 21, 2023
…updates in the default user agents (javiereguiluz) This PR was merged into the 6.3 branch. Discussion ---------- [BrowserKit][HttpClient] [BrowserKit, HttpClient] Minor updates in the default user agents | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - After merging #50053 I realized that some of my changes were not really needed. According to the spec, the user agent _"consists of one or more product identifiers, each followed by zero or more comments"_ For example this user agent: ``` Mozilla/5.0 (iPad; U; CPU OS 3_2_1 like Mac OS X; en-us) AppleWebKit/531.21.10 (KHTML, like Gecko) Mobile/7B405 ``` `Mozilla/5.0` is the product and version `AppleWebKit/531.21.10` is a subproduct and its own version In both cases the version is optional. So, our user agent `Symfony BrowserKit` is correct: * `Symfony` is the product, without version (completely legal) * `BrowserKit` is the subproduct, and omits its version (legal too) The real issue was with user agents like `Symfony HttpClient/Amp`, because `/Amp` would be interpreted as the version of the `HttpClient`, which is wrong (the version is `6.2`, `6.3`, etc.). The `Amp` text is a detail about a product, so it's common to wrap it in parenthesis. So, sorry for the noise and I think this time this is fully correct. Thanks. Commits ------- e4d3203 [BrowserKit, HttpClient] Minor updates in the default user agents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.