📖 Use Should instead of To in komega samples#2770
📖 Use Should instead of To in komega samples#2770k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Should instead of To in komega samples#2770Conversation
As the `AsyncAssertion` of `gomega` does not support `To` the samples in the documentation have been updated to use `Should`.
|
Welcome @afritzler! |
|
Hi @afritzler. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Nice catch, thx! /lgtm /ok-to-test |
|
LGTM label has been added. DetailsGit tree hash: a35e51006af665d8c29a12f3b67f06a151aa4ffd |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afritzler, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As the
AsyncAssertionofgomegadoes not supportTothe samples in the documentation have been updated to useShould.