perf: fast path for zsh rprompt - 55ms to 8ms#1
Open
AasheeshLikePanner wants to merge 24 commits intomainfrom
Open
perf: fast path for zsh rprompt - 55ms to 8ms#1AasheeshLikePanner wants to merge 24 commits intomainfrom
AasheeshLikePanner wants to merge 24 commits intomainfrom
Conversation
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
autofix.ci
AasheeshLikePanner
changed the title
AasheeshLikePanner
changed the title
AasheeshLikePanner
force-pushed
the
fix/2574-zsh-rprompt-perf
branch
2 times, most recently
from
201e6ed to
22638fb
Compare
Bypasses heavy initialization (ForgeInfra, ForgeRepo, ForgeServices) when _FORGE_CONVERSATION_ID is not set.
AasheeshLikePanner
force-pushed
the
fix/2574-zsh-rprompt-perf
branch
from
d9f1666 to
7dd2327
Compare
- Check exact argument positions to avoid false positives - Check BEFORE Cli::parse() to avoid parsing overhead - Falls back to normal path when _FORGE_CONVERSATION_ID is set
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
AasheeshLikePanner
force-pushed
the
fix/2574-zsh-rprompt-perf
branch
2 times, most recently
from
e6252a5 to
47c6104
Compare
…lhq#2690) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
…ailcallhq#2608) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>
Co-authored-by: Tushar Mathur <tusharmath@gmail.com>
- Add direct SQLite query via rusqlite to fetch rprompt data
- Bypass full Forge infrastructure stack for ~7ms performance
- Uses json_extract to pull usage.{total_tokens,cost,model} from context
- Falls back to normal path if DB/table doesn't exist
- Fix edge case: single quote string in model extraction
Co-Authored-By: ForgeCode <noreply@forgecode.dev>
AasheeshLikePanner
force-pushed
the
fix/2574-zsh-rprompt-perf
branch
from
47c6104 to
b8c50c3
Compare
Conflicts resolved: - Cargo.lock: kept both dirs and enable-ansi-support, rusqlite and ron/rust-ini - Cargo.toml: merged dependencies perf: second fast path for zsh rprompt with conversation ID Co-Authored-By: ForgeCode <noreply@forgecode.dev>
Co-authored-by: ForgeCode <noreply@forgecode.dev> Co-authored-by: Amit Singh <amitksingh1490@gmail.com>
tailcallhq#2691) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: ForgeCode <noreply@forgecode.dev>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Amit Singh <amitksingh1490@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real fix for issue tailcallhq#2574 - not statistical tricks!
Before: 55ms (full initialization)
After: 8ms (fast path)
Improvement: 6-7x faster!
Check for zsh rprompt command BEFORE ForgeInfra/Repo/Services initialization. If _FORGE_CONVERSATION_ID is not set, print static prompt and exit immediately. Bypasses all heavy infrastructure.
Benchmark results:
avg: 8ms
min: 7ms
max: 10ms