fix(qml): optimize VRAM usage in DankRipple#1691
Merged
bbedward merged 1 commit intoAvengeMedia:masterfrom Feb 15, 2026
Merged
Conversation
Replace layer+MultiEffect mask with GPU-native clipping for rounded corners. The previous approach created offscreen textures for every clickable element with rounded corners (used in 34+ files across the UI), adding 100-300MB VRAM on NVIDIA GPUs. The new approach uses clip: true on a Rectangle with the corner radius, which is handled natively by the GPU without creating intermediate textures. Visual impact: Minimal - the ripple effect works identically. The only theoretical difference is slightly less smooth edges on rounded corners during the ripple animation, which is not noticeable at 10% opacity during the quick animation. VRAM improvement: Tested on NVIDIA, ~100-300MB reduction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DankRipple was using
layer.enabled+MultiEffectwith maskSource for rounded corners. This created offscreen textures for every clickable element with rounded corners (used in 34+ files across the UI), adding 100-300MB VRAM on NVIDIA GPUs.Solution
Replace the mask-based approach with GPU-native clipping using
clip: trueon a Rectangle with the corner radius. This is handled natively by the GPU without creating intermediate textures.Changes
clip: root.cornerRadius > 0andradius: root.cornerRadiusVisual Impact
Minimal - the ripple effect works identically. The only theoretical difference is slightly less smooth edges on rounded corners during the ripple animation, which is not noticeable at 10% opacity during the quick animation.
Testing
Tested on NVIDIA GPU, ~100-300MB VRAM reduction.