screensaver: emit ActiveChanged on lock/unlock#1761
Merged
bbedward merged 1 commit intoAvengeMedia:masterfrom Feb 20, 2026
Merged
screensaver: emit ActiveChanged on lock/unlock#1761bbedward merged 1 commit intoAvengeMedia:masterfrom
bbedward merged 1 commit intoAvengeMedia:masterfrom
Conversation
bbedward
pushed a commit
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1760
Summary
ActiveChanged(bool)gets emitted on the session bus when the screen locks/unlocksorg.freedesktop.ScreenSaverandorg.gnome.ScreenSaverindependently -- if one is already taken by the compositor, the other still worksGetActive/SetActive/Lockmethods to the screensaver D-Bus interfaceClose()not cleaning up screensaver subscriber channelsContext
Apps like Bitwarden listen for
ActiveChangedonorg.freedesktop.ScreenSaver/org.gnome.ScreenSaverto detect screen lock. The screensaver module only handled idle inhibition and had no lock state awareness, so these apps never saw lock events.The old code also bailed out entirely if
org.freedesktop.ScreenSaverwas already owned by another process, which left the whole module dead on compositors that claim that name for idle inhibiting.Now both names are claimed independently and a bridge goroutine subscribes to loginctl state changes to forward lock/unlock events as
ActiveChangedsignals on the session bus.Test plan
make fmt/make testpassGetActiveresponds on the session busActiveChanged(true)emitted on lockActiveChanged(false)emitted on unlock