Enhance comments in docker-compose.yml for headless usage#1081
Enhance comments in docker-compose.yml for headless usage#1081DrewThomasson merged 17 commits intov25from
Conversation
There was one comma replaced with a less than (,<) so I fixed it.
Update pyproject.toml
Added comments to clarify usage of docker-composenf or headless usage
Added a section for Compose headless setup in the README.
Clarify the purpose of the docker-compose.yml file.
Added comments to clarify usage of podman-compose.yml.
|
@ROBERT-MCDOWELL 👍 ? |
|
I'm not sure to understand what do you mean by The is it the same as "in headless mode, The a file becoming a base directory? or the docker-compose.yml parent directory? |
|
@ROBERT-MCDOWELL HM Good catch, that was poorly worded. The directory containing This means any file in the project root on your local machine is accessible inside the container. To illustrate, here's how the paths for the same file look:
So, to process a local file like About the "in headless mode"Ignore the "in headless mode" Phrasing.... I just wanted to give an example of if someone wanted to use the compose with a headless command is all |
|
Should I remove this from the readme then? "The |
|
ok more clear! so if I move docker-compose.yml out of E2A folder. will it be the parent folder of the yml? |
|
Yes! |
|
Perhaps I should try creating a wiki page for this or something |
Updated example command in podman-compose.yml to reflect new file path.
|
Hows this? Should I re-word the comments made in the docker-compose and podman-compose files? |
|
👌👍 |
Changed when copy application files to before the launch This makes it so that the compose user does not have to re-build the unidic step every time the compose is launched
|
Hopefully that dockerfile optomization works too, That should stop the compose from re-building the last unidict/pip install step everything its launched Because it should just launch the dockerfile you built before instead of re-building partly every time ✨ |
Updated comments for clarity regarding the base directory and headless command usage.
Updated comments for clarity and improved instructions.
Added a link to the Headless Wiki for more information.
|
indeed! |
|
So that updated wording looks good to you? :D |
|
LGTM! |
Updated instructions for starting services with Docker and Podman to clarify the use of the --build flag.
|
kk ill merge once the tests go through |
Updated example headless command in podman-compose.yml for clarity.
3 participants
Added comments to clarify usage of docker-composenf or headless usage