Skip to content

Update E2A Test workflow for multi-OS support#1141

Merged
DrewThomasson merged 3 commits intov25from
DrewThomasson-workflow-patch-1
Nov 19, 2025
Merged

Update E2A Test workflow for multi-OS support#1141
DrewThomasson merged 3 commits intov25from
DrewThomasson-workflow-patch-1

Conversation

@DrewThomasson
Copy link
Owner

Refactor E2A Test workflow to support both macOS and Linux environments.

@DrewThomasson
Copy link
Owner Author

I have created a new Ubuntu runner

This will utilize that

But the caviot is that the Docker build and hugginface build Workflows will not run until Both the Mac and Ubuntu Runners have completed all of their tests

@ROBERT-MCDOWELL is this good for you?

or would you rather have the Docker and hugginface workflows only require that the Mac E2A test completes and not waiting on the slow Ubuntu x86 (no gpu) tests?

@DrewThomasson
Copy link
Owner Author

@ROBERT-MCDOWELL

As you can see the Linux and Mac workflows run independently but in paralell

almost as if they both have their own separate workflow files

https://github.com/DrewThomasson/ebook2audiobook/actions/runs/19453820039

@DrewThomasson
Copy link
Owner Author

First I need to run the ebook2audiobook.sh manually in order to install all the base stuff for the Ubuntu runner to run correctly like conda and such

Updated conda deactivate command to suppress errors in E2A-Test workflow.
@ROBERT-MCDOWELL
Copy link
Collaborator

fixed custom model upload. the tests can be run again. if everything ok so you can merge it and I will prepare the release tomorrow, there is some important point the user must do before to update, like empty the tmp folder.

@DrewThomasson
Copy link
Owner Author

intesting https://github.com/DrewThomasson/ebook2audiobook/actions/runs/19454354846

it appears that the issue with ubuntu is still there with the installation of calibre

the only thing that seems to fix this is to install Calibre with the

sudo -v && wget -nv -O- https://download.calibre-ebook.com/linux-installer.sh | sudo sh /dev/stdin

@DrewThomasson
Copy link
Owner Author

DrewThomasson commented Nov 18, 2025

Should we make it so that it installs calibre like that on specifially Ubuntu or...

the apt-get calibre isnt seem by ebook2audiobook for some reason for Ubuntu

@DrewThomasson
Copy link
Owner Author

wait...

@DrewThomasson
Copy link
Owner Author

DrewThomasson commented Nov 18, 2025

Testing Theory right now on the ubuntu machine

By manually installing calibre as said on their website
https://calibre-ebook.com/download_linux

@DrewThomasson
Copy link
Owner Author

Confirmed to fix issue with Ubuntu

Still do not know why this is a thing on but ubuntu but idk
@ROBERT-MCDOWELL

@DrewThomasson
Copy link
Owner Author

@ROBERT-MCDOWELL

hm....

https://github.com/DrewThomasson/ebook2audiobook/actions/runs/19454354846/job/55666046990

idk why the OCR is failing specifially on the Ubuntu

I'll test on v25 for just mac and see wha th happens

@DrewThomasson
Copy link
Owner Author

DrewThomasson commented Nov 18, 2025

OCR does work on mac confirmed

But its not working on the Ubuntu runner?
@ROBERT-MCDOWELL

@DrewThomasson
Copy link
Owner Author

fixed custom model upload. the tests can be run again. if everything ok so you can merge it and I will prepare the release tomorrow, there is some important point the user must do before to update, like empty the tmp folder.

Running on v25 branch to test again for mac only

@ROBERT-MCDOWELL
Copy link
Collaborator

OCR does work on mac confirmed

But its not working on the Ubuntu runner? @ROBERT-MCDOWELL

which version of ubuntu? on my side 20.04 is ok. they certainly changed package name or else.
it must be very careful about which calibre is installed since there are some package not providing cli app like ebook-converter, some have not the right options available etc...

@DrewThomasson
Copy link
Owner Author

DrewThomasson commented Nov 18, 2025

@ROBERT-MCDOWELL

Should I merge this into the v25?

This workflow does work at this point

@ROBERT-MCDOWELL
Copy link
Collaborator

yes

@DrewThomasson
Copy link
Owner Author

Kk merging

@DrewThomasson DrewThomasson merged commit 65930f9 into v25 Nov 19, 2025
@DrewThomasson DrewThomasson deleted the DrewThomasson-workflow-patch-1 branch November 19, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants