Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the get_audio_duration function by moving it from lib/core.py to lib/classes/tts_engines/common/audio.py for better code organization. It also updates the VTT file generation to use get_audio_duration instead of pydub's AudioSegment for calculating audio duration.
Changes:
- Moved
get_audio_durationfunction fromlib/core.pytolib/classes/tts_engines/common/audio.py - Replaced pydub AudioSegment usage with
get_audio_durationin VTT file generation - Removed pydub dependency from utils.py
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/core.py | Removed get_audio_duration function and added import from the new location |
| lib/classes/tts_engines/common/audio.py | Added get_audio_duration function (but creates duplicate definition) |
| lib/classes/tts_engines/common/utils.py | Removed pydub dependency and updated to use get_audio_duration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.