Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR (v25.12.33) includes multiple bug fixes, code improvements, and cleanup across the TTS engine infrastructure.
Changes:
- Fixed typos, duplicate code, and incorrect method references
- Added missing
device_typeparameter totorch.autocast()calls for proper PyTorch API usage - Improved error handling and error messages
- Enhanced ffmpeg command structure with progress reporting
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/core.py | Reformatted ffmpeg command with better readability and added progress pipe; improved session info message grammar |
| lib/classes/tts_engines/xtts.py | Removed duplicate self.speaker = None initialization; added device_type parameter to torch.autocast() |
| lib/classes/tts_engines/yourtts.py | Added device_type parameter to torch.autocast() |
| lib/classes/tts_engines/vits.py | Added device_type parameter to torch.autocast() in two locations |
| lib/classes/tts_engines/tacotron.py | Added device_type parameter to torch.autocast() in two locations |
| lib/classes/tts_engines/fairseq.py | Added device_type parameter to torch.autocast() in two locations |
| lib/classes/tts_engines/bark.py | Added device_type parameter to torch.autocast() in two locations |
| lib/classes/tts_engines/common/utils.py | Fixed typo "srror" to "error"; corrected method call from set_voice to _set_voice; improved error handling; added type safety with str() wrapper |
| lib/classes/tts_engines/common/audio.py | Improved error messages; removed duplicate get_audio_duration() function definition; added type safety with str() wrapper |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.