Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces Docker container memory detection support and fixes a potential bug in session restoration. The changes add a new script_mode parameter to the VRAM detection system to enable specialized memory handling for Docker environments.
Changes:
- Added Docker-specific memory detection logic in VRAMDetector class
- Fixed defensive check for custom_model_dir validation in session restoration
- Updated all detect_vram method calls to include the new script_mode parameter
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/gradio.py | Fixed potential KeyError by adding defensive check for custom_model_dir existence before using os.path.exists() |
| lib/core.py | Added script_mode parameter to detect_vram call |
| lib/classes/vram_detector.py | Added Docker detection methods, updated detect_vram signature with script_mode parameter, improved memory calculation logic |
| lib/classes/tts_engines/common/utils.py | Updated three detect_vram calls to include script_mode parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.