Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project to version 25.12.33 with significant refactoring of audio processing and various code improvements.
Changes:
- Refactored audio processing to use multiprocessing with progress tracking via queues for better concurrency and user feedback
- Renamed functions and variables for clarity (e.g.,
assemble_chunks→assemble_audio_chunks_worker,percentage→percent) - Fixed environment variable handling in build scripts and consolidated import statements
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/core.py | Major refactoring of audio processing functions with multiprocessing queue-based progress tracking, function renaming, and code style improvements |
| lib/classes/subprocess_pipe.py | Added on_progress callback parameter and new _emit_progress method for flexible progress reporting |
| lib/classes/vram_detector.py | Simplified _ceil_gb method and moved variable declaration |
| ebook2audiobook.sh | Reorganized environment variable exports for better code organization |
| ebook2audiobook.cmd | Fixed environment variable assignment syntax and added DEVICE_TAG synchronization |
| Dockerfile | Updated default APP_VERSION |
| .github/FUNDING.yml | Added custom funding URL |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.