Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR (v26.2.26) enhances error handling and input validation across multiple TTS engine classes. The changes add defensive programming practices by validating session parameters and model configurations before use, providing clearer error messages when issues occur.
Changes:
- Added comprehensive validation for
tts_engine,language, andfine_tunedparameters in TTS engine constructors - Replaced direct dictionary key access with safer
.get()calls followed by validation checks - Standardized error messages across TTS engines with consistent formatting
- Removed unnecessary blank lines in app.py documentation
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/classes/tts_engines/vits.py | Added validation for tts_engine, language, fine_tuned parameters and required model configuration keys; improved error messages |
| lib/classes/tts_engines/tortoise.py | Added validation for tts_engine, language, fine_tuned parameters and required model configuration keys; improved error messages |
| lib/classes/tts_engines/tacotron.py | Added validation for tts_engine, language, fine_tuned parameters and required model configuration keys; improved error messages |
| lib/classes/tts_engines/glowtts.py | Added validation for tts_engine, language, fine_tuned parameters and required model configuration keys; improved error messages |
| lib/classes/tts_engines/fairseq.py | Added validation for fine_tuned parameter and repo key in model configuration |
| lib/classes/tts_engines/bark.py | Added validation for fine_tuned parameter and repo key in model configuration |
| app.py | Removed unnecessary blank lines in help text formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.