Make BigInteger and BigDecimal parsing lazy#828
Conversation
|
@pjfanning Excellent! I am thinking I do need to release I hope testing we have is able to find edge cases there might be but... we'll see. |
BigInteger parsing lazy
|
@pjfanning One thing we could do eagerly would to add accessor (I renamed one here to in hindsight these probably should have been there from beginning. |
|
@cowtowncoder I've made big decimal lazy too and renamed the private methods |
BigInteger parsing lazyBigInteger and BigDecimal parsing lazy
|
@pjfanning Is there a PR? I merged this one earlier. |
|
@cowtowncoder I created #830 - I hadn't noticed that this PR was merged and thought that my changes in the related branch would update this PR |
|
Ah. Thank you for creating a new PR, I think updates after merge may not be visible. |
@cowtowncoder please feel free to reject this - but this relatively small change might be useful for v2.14
This is useful for rallyhealth/weePickle#118
This change means that JsonParser.getNumberType will not need to parse the BigInteger but if you later need the BigInteger (getBigIntegerValue() call), it will then be parsed (just once).
It may also be useful to do something similar with BigDecimal parsing but that change is not as immediately useful.