Allow to use CO in readjustService.ps1 #236
Open
asymcon wants to merge 2 commits intoFlyGoat:masterfrom
Open
Conversation
Falcosc
reviewed
Dec 20, 2022
| adjust "fast_limit" 46000 | ||
| adjust "slow_limit" 25000 | ||
| #adjust "slow_time" 30 | ||
| #adjust "coall" 4294967266 #Curve optimizer at -30 |
Collaborator
There was a problem hiding this comment.
I didn't check this parameter, but does the CLI version also require unsigned int?
Would it be possible to use a signed int and directly use -30?
Collaborator
There was a problem hiding this comment.
@asymcon could you please change it to signed int to be able to use -30 directly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_coall,set_coperandset_cogfxwere not imported from libryzenadj.dll, calls from readjustService.ps1 would result in "Method invocation failed" error. This should fix it.