fix(src): fix getProcessStartingTimestamp function#1134
Merged
jmcook1186 merged 1 commit intoGreen-Software-Foundation:mainfrom May 6, 2025
Merged
Conversation
The getProcessStartingTimestamp function was using hrtime but wasn't correctly calculating the process start time. Therefore, modify it to use uptime for the calculation instead. Additionally, change it to use the standard Date object instead of luxon, as the rich features provided by luxon weren't necessary. Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com>
jmcook1186
approved these changes
May 6, 2025
Contributor
jmcook1186
left a comment
jmcook1186
left a comment
There was a problem hiding this comment.
seems ok to me - thanks!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
A description of the changes proposed in the Pull Request
The
getProcessStartingTimestampfunction was using hrtime but wasn't correctly calculating the process start time.Therefore, modify it to use uptime for the calculation instead.
Additionally, change it to use the standard
Dateobject instead of luxon, as the rich features provided by luxon weren't necessary.Note: When
hrtimeis called without arguments, it returns the elapsed time from some point (not specified in the API), rather than returning the value of the process start time.