Conversation
p-hoffmann
requested review from
SantanM,
Zhimin-arya,
alicia-koh,
brandantck,
csafreen,
mwaiyee,
satish-a0 and
suwarnoong
as code owners
There was a problem hiding this comment.
Pull request overview
Moves the “flows” workspace under plugins/flows and updates tooling/CI configuration to reflect the new directory layout.
Changes:
- Updated GitHub Actions workflows to detect/build/test flows from
plugins/flows/**paths. - Updated local dev tooling (docker-compose mount hints, VS Code debug path mapping) and internal docs to use the new location.
- Updated CODEOWNERS entries to match the moved flows directory.
Reviewed changes
Copilot reviewed 10 out of 546 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docker-compose-local.yml | Updates the commented local mount path for flows development. |
| .vscode/launch.json | Adjusts VS Code debugger local path mapping for moved flows directory. |
| .github/workflows/test_strategus_nodes.yml | Updates Strategus workflow path filters and compose file path to new location. |
| .github/workflows/plugin-ci.yml | Updates CI filters and plugin matrix package paths to plugins/flows. |
| .github/workflows/docker-build-push.yaml | Updates build filters and docker build contexts/Dockerfile paths to plugins/flows. |
| .github/workflows/d2e-demosetup-hana.yml | Updates base flow path filter and docker build command paths. |
| .github/workflows/d2e-demosetup-dev.yml | Updates path filters, docker build paths, and sed replacement to new mount line. |
| .github/instructions/flows.instructions.md | Updates developer instructions to reference plugins/flows directory structure. |
| .github/CODEOWNERS.src | Updates code ownership paths for flows under plugins/flows. |
| .github/CODEOWNERS | Updates code ownership paths for flows under plugins/flows. |
| { | ||
| "localRoot": "${workspaceFolder}/flows", | ||
| "localRoot": "${workspaceFolder}/plugins/flows", | ||
| "remoteRoot": "./flows" |
There was a problem hiding this comment.
localRoot was updated to plugins/flows, but remoteRoot still points to ./flows. This will likely break source mapping during remote debugging after the move. Update remoteRoot to the actual remote path where the flows code lives now (e.g., ./plugins/flows), or keep both sides consistent with whatever path the container/runtime uses.
| "remoteRoot": "./flows" | |
| "remoteRoot": "./plugins/flows" |
| /flows @alicia-koh @csafreen @Zhimin-arya @p-hoffmann | ||
| /flows/strategus_plugin @hengxian-jiang @KangJingA @SantanM @suwarnoong @p-hoffmann | ||
| /plugins/flows @alicia-koh @csafreen @Zhimin-arya @p-hoffmann | ||
| /plugins/flows/strategus_plugin @hengxian-jiang @KangJingA @SantanM @suwarnoong @p-hoffmann |
There was a problem hiding this comment.
The CODEOWNERS entry for Strategus doesn’t match the updated workflow paths in this PR (which reference plugins/flows/hades/strategus_plugin/**). As written, /plugins/flows/strategus_plugin won’t apply if the Strategus plugin is nested under a flow group (e.g., hades). Update this rule to match the real location (e.g., /plugins/flows/hades/strategus_plugin or a wildcard like /plugins/flows/**/strategus_plugin).
| /plugins/flows/strategus_plugin @hengxian-jiang @KangJingA @SantanM @suwarnoong @p-hoffmann | |
| /plugins/flows/**/strategus_plugin @hengxian-jiang @KangJingA @SantanM @suwarnoong @p-hoffmann |
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)