Skip to content

Run dqd and dc hana through trex#1961

Draft
alicia-koh wants to merge 1 commit intodevelopfrom
alicia-koh/trex-hana-1
Draft

Run dqd and dc hana through trex#1961
alicia-koh wants to merge 1 commit intodevelopfrom
alicia-koh/trex-hana-1

Conversation

@alicia-koh
Copy link
Collaborator

Merge Checklist

Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.

  • Automated Tests (Jasmine integration tests, Unit tests, and/or Performance tests)
  • Updated Manual tests / Demo Config
  • Documentation (Application guide, Admin guide, Markdown, Readme and/or Wiki)
  • Verified that local development environment is working with latest changes (integrated with latest develop branch)
  • following best practices in code review doc

is_hana_jwt_auth = dbdao.tenant_configs.authMode == AuthMode.JWT and dbdao.dialect == SupportedDatabaseDialects.HANA

# Todo: Update implementation if Hana JWT uses trex
use_trex_connection = False if is_hana_jwt_auth else options.use_trex_connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant