[PA] Rename filtercard dialog does not have feedback when saving#2002
Open
khairul-syazwan wants to merge 2 commits intodevelopfrom
Open
[PA] Rename filtercard dialog does not have feedback when saving#2002khairul-syazwan wants to merge 2 commits intodevelopfrom
khairul-syazwan wants to merge 2 commits intodevelopfrom
Conversation
khairul-syazwan
requested review from
LSriragavan,
brandantck,
jerome-ng,
maggie-li-yd,
p-hoffmann and
satish-a0
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds “saving” feedback to the rename dialog flow by wiring a busy/loading state through the dialog and disabling actions during the rename request.
Changes:
- Add
isRenamingBookmarkstate and pass it to<messageBox :busy="...">to show a loading indicator while renaming. - Disable Save/Cancel actions and prevent closing the dialog while a rename request is in-flight.
- Convert
confirmRenameBookmarktoasync/awaitfor sequential request handling.
maggie-li-yd
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1987
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)