Skip to content

github-workflow: workflow_call.secrets.*.required is not required#4635

Merged
hyperupcall merged 1 commit intoSchemaStore:masterfrom
woodruffw-forks:ww/rm-required-from-required
Apr 6, 2025
Merged

github-workflow: workflow_call.secrets.*.required is not required#4635
hyperupcall merged 1 commit intoSchemaStore:masterfrom
woodruffw-forks:ww/rm-required-from-required

Conversation

@woodruffw
Copy link
Copy Markdown
Contributor

Hi SchemaStore maintainers! Thank you for all the hard work you've done here.

This removes required from the required set, since GitHub Actions does not actually require this field to be set.

Corroborating evidence:

See zizmorcore/zizmor#646 for additional context as well.

This removes `required` from the `required` set, since
GitHub Actions does not actually require this field to be set.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2025

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall hyperupcall merged commit a0e6765 into SchemaStore:master Apr 6, 2025
5 checks passed
@hyperupcall
Copy link
Copy Markdown
Member

Thanks!

@woodruffw
Copy link
Copy Markdown
Contributor Author

Thanks for the fast merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants