fix: #25882 persist required singleton inlines with default-only values on add#121
Merged
MartinCervenkaSB merged 3 commits intomainfrom Mar 23, 2026
Merged
fix: #25882 persist required singleton inlines with default-only values on add#121MartinCervenkaSB merged 3 commits intomainfrom
MartinCervenkaSB merged 3 commits intomainfrom
Conversation
Django treats extra inline forms with only default values as unchanged, so they can be skipped during create. For parent add flow, we now force changed state for min=max=1 inlines so the inline form is validated and the related object is created.
added 2 commits
March 20, 2026 11:43
…clean Move singleton add handling to formset validation flow and gate it by validate_min/validate_max on SBAdminInline. For required singletons (min=max=1), default-only inline forms are forced as changed during parent creation so min validation can pass and the related object can be created.
ViktorBojda
changed the title
ViktorBojda
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Django treats extra inline forms with only default values as unchanged, so they can be skipped during create. For parent add flow, we now force changed state for min=max=1 inlines so the inline form is validated and the related object is created.