Skip to content

Restore NO_GUI compilation#4849

Open
gzotti wants to merge 16 commits intomasterfrom
fix/NO_GUI
Open

Restore NO_GUI compilation#4849
gzotti wants to merge 16 commits intomasterfrom
fix/NO_GUI

Conversation

@gzotti
Copy link
Copy Markdown
Member

@gzotti gzotti commented Apr 1, 2026

Description

For several years now (really since 2010?) the non-Widget-GUI compilation was not maintained. While not useful in general setups as sole installation in a system, maybe as purely pre-configured RemoteControlled or scripted setups it may still have its value.

Fixes # (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: Windows 11
  • Graphics Card: Geforce (but irrelevant)

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gzotti gzotti added this to the 26.2 milestone Apr 1, 2026
@gzotti gzotti self-assigned this Apr 1, 2026
@gzotti gzotti added the importance: low Small problem, rarely visible, no crash label Apr 1, 2026
@gzotti gzotti added this to GUI Apr 1, 2026
@github-project-automation github-project-automation bot moved this to Backlog in GUI Apr 1, 2026
@github-actions github-actions bot requested review from 10110111 and alex-w April 1, 2026 12:27
@gzotti
Copy link
Copy Markdown
Member Author

gzotti commented Apr 3, 2026

Shouldn't we rename the STELLARIUM_GUI_MODE options from (Standard/None) to (QWidgets/None)? Just in case someone writes a new "Standard"...

@10110111
Copy link
Copy Markdown
Contributor

10110111 commented Apr 3, 2026

Shouldn't we rename the STELLARIUM_GUI_MODE options from (Standard/None) to (QWidgets/None)? Just in case someone writes a new "Standard"...

Well, someone could write a new one using QWidgets too. If we get a new GUI that becomes the new standard, it can just be called Modern or something.

@gzotti
Copy link
Copy Markdown
Member Author

gzotti commented Apr 3, 2026

Hmm, replacing QWidgets with QWidgets is nothing I expect to happen... but OK, it needs anything else to happen. Just that I need to write this name into several CMakefiles, so an earlier decision saves later re-edits.

@gzotti gzotti force-pushed the fix/NO_GUI branch 2 times, most recently from 6372eeb to 0f77798 Compare April 4, 2026 18:15
@gzotti gzotti marked this pull request as ready for review April 5, 2026 14:36
@gzotti
Copy link
Copy Markdown
Member Author

gzotti commented Apr 5, 2026

Also this mode needs the QWidget library because of the ProgressBar. For now it should be done. Purpose is a (slightly generalized) specialized installation that may become more useful with #4813. Docs are in BUILDING.md.

@gzotti
Copy link
Copy Markdown
Member Author

gzotti commented Apr 9, 2026

@alex-w IMO this should go in before we evaluate the very interesting RemoteControl GUI changes. Any comments or reservations?

@github-actions github-actions bot added the has conflicts The pull request has conflicts label Apr 14, 2026
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot removed the has conflicts The pull request has conflicts label Apr 14, 2026
@github-actions
Copy link
Copy Markdown

Conflicts have been resolved. A maintainer will review the pull request shortly.

@gzotti
Copy link
Copy Markdown
Member Author

gzotti commented Apr 14, 2026

@alex-w Any objections here?

@10110111
Copy link
Copy Markdown
Contributor

Should we maybe add a CI instance to make sure this doesn't break unnoticed later?

@alex-w
Copy link
Copy Markdown
Member

alex-w commented Apr 15, 2026

Should we maybe add a CI instance to make sure this doesn't break unnoticed later?

I've added a CI instance and I see troubles in plugins :(

Copy link
Copy Markdown
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need fix the compilation with -DSTELLARIUM_GUI_MODE=None option

@gzotti
Copy link
Copy Markdown
Member Author

gzotti commented Apr 15, 2026

Thanks for setting this up. Must see what fails here.
Given that this still needs QWidgets, maybe the QTextWidgets for InfoText should also be re-activated immediately. (we wrote text directly to screen in earlier times, with that panel as fallback when text rendering was broken on some systems.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

importance: low Small problem, rarely visible, no crash

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants