Conversation
|
Shouldn't we rename the STELLARIUM_GUI_MODE options from (Standard/None) to (QWidgets/None)? Just in case someone writes a new "Standard"... |
Well, someone could write a new one using QWidgets too. If we get a new GUI that becomes the new standard, it can just be called Modern or something. |
|
Hmm, replacing QWidgets with QWidgets is nothing I expect to happen... but OK, it needs anything else to happen. Just that I need to write this name into several CMakefiles, so an earlier decision saves later re-edits. |
6372eeb to
0f77798
Compare
|
Also this mode needs the QWidget library because of the ProgressBar. For now it should be done. Purpose is a (slightly generalized) specialized installation that may become more useful with #4813. Docs are in BUILDING.md. |
|
@alex-w IMO this should go in before we evaluate the very interesting RemoteControl GUI changes. Any comments or reservations? |
This comment was marked as outdated.
This comment was marked as outdated.
…plugins - In Observability, also refactor: rename enabling flag, store/retrieve
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
@alex-w Any objections here? |
|
Should we maybe add a CI instance to make sure this doesn't break unnoticed later? |
I've added a CI instance and I see troubles in plugins :( |
alex-w
left a comment
There was a problem hiding this comment.
Need fix the compilation with -DSTELLARIUM_GUI_MODE=None option
|
Thanks for setting this up. Must see what fails here. |
Description
For several years now (really since 2010?) the non-Widget-GUI compilation was not maintained. While not useful in general setups as sole installation in a system, maybe as purely pre-configured RemoteControlled or scripted setups it may still have its value.
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: