fix(ios): IMA ad container resizing on orientation change#4771
Merged
moskalakamil merged 4 commits intoTheWidlarzGroup:support/6.x.xfrom Mar 9, 2026
Merged
Conversation
github-project-automation
bot
moved this to To Triage
in React Native Video - Public Roadmap
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the IMA ad container view did not resize correctly when the device orientation changed on iOS. The solution replaces frame-based layout with Auto Layout constraints.
Key Changes:
- Added Auto Layout constraints to pin the
adContainerViewto all edges of_video - Set
translatesAutoresizingMaskIntoConstraints = falseto enable constraint-based layout - Ensures the ad container properly resizes during orientation changes while preserving the existing memory leak fix
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
moskalakamil
approved these changes
Nov 19, 2025
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
moskalakamil
changed the title
github-project-automation
bot
moved this from To Triage
to Done
in React Native Video - Public Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the IMA ad container view did not resize correctly when device orientation changed on iOS.
Previously, adContainerView was initialised with a static frame (_video.bounds), so it didn’t update after rotation.
🛠️ Changes
Replaced frame-based layout with Auto Layout constraints to pin adContainerView to _video on all edges.
Ensures proper resizing on orientation change while retaining the existing memory leak fix.
Tested on iOS 15.1+ (iPhone simulators) — ads now stay correctly aligned after rotation.
✅ Verification
Verified that ads render correctly in both portrait and landscape modes.
Confirmed no new memory leaks or constraint warnings.
Maintains backward compatibility with existing React Native Video integrations.