Fix text and image multimodal support so that it properly works regardless of capability chosen#14
Merged
felixarntz merged 3 commits intotrunkfrom Mar 16, 2026
Conversation
…age generation for multimodal models
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dkotter
approved these changes
Mar 9, 2026
JasonTheAdams
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, the Gemini multimodal text and image models were only working when used for the
image_generationcapability, even though they technically support bothtext_generationandimage_generation.They always were able to create both in our implementation, but the routing (model metadata plus class interfaces implemented) was not quite right.
This PR fixes the last important bit, by introducing a class that implements both the
generateTextResultandgenerateImageResultmethods.cc @dkotter