Skip to content

Fix text and image multimodal support so that it properly works regardless of capability chosen#14

Merged
felixarntz merged 3 commits intotrunkfrom
fix/proper-text-and-image-multimodal-support
Mar 16, 2026
Merged

Fix text and image multimodal support so that it properly works regardless of capability chosen#14
felixarntz merged 3 commits intotrunkfrom
fix/proper-text-and-image-multimodal-support

Conversation

@felixarntz
Copy link
Copy Markdown
Member

So far, the Gemini multimodal text and image models were only working when used for the image_generation capability, even though they technically support both text_generation and image_generation.

They always were able to create both in our implementation, but the routing (model metadata plus class interfaces implemented) was not quite right.

This PR fixes the last important bit, by introducing a class that implements both the generateTextResult and generateImageResult methods.

cc @dkotter

@felixarntz felixarntz added this to the 1.1.0 milestone Mar 7, 2026
@felixarntz felixarntz requested a review from JasonTheAdams March 7, 2026 20:58
@felixarntz felixarntz added the bug Something isn't working label Mar 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: dkotter <dkotter@git.wordpress.org>
Co-authored-by: JasonTheAdams <jason_the_adams@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@felixarntz felixarntz merged commit f8ba19c into trunk Mar 16, 2026
2 checks passed
@jeffpaul jeffpaul deleted the fix/proper-text-and-image-multimodal-support branch April 9, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants