Revision: "Set as featured image" option appears in image block

[shimotmk]

Description

The revision screen is for viewing revisions, so is it correct that it allows setting a featured image?

Step-by-step reproduction instructions

1. Go to post or page.
2. Insert an image block.
3. Go to the revision screen.
4. You will notice that "Set as featured image" appears as an option in the image block.

Screenshots, screen recording, code snippet

Environment info

• WordPress 7.0-beta2

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[sidhant-tomar-003]

I also tested and was able to reproduce the issue.

Environment info:
7.0-beta2-61788 (wp-env)

I also checked some of the JS APIs on the console and by the looks of it, its possible that the image block just isn't specific enough with its checks and logic to display this option.

wp.data.select('core/editor').getCurrentPostType()
'post'
wp.data.select('core/editor').isEditedPostSaveable()
true
wp.data.select('core/editor').getCurrentPost().status
'publish'

Though its also possible the editing environment in the UI isn't being set correctly. I'll have to look closer for that.

I went ahead and looked at the code, it looks like this if statement might be missing something:

const featuredImageControl = (
		<BlockSettingsMenuControls>
			{ ( { selectedClientIds } ) =>
				selectedClientIds.length === 1 &&
				! isDescendentOfQueryLoop &&
				postId &&
				id &&
				clientId === selectedClientIds[ 0 ] && (
					<MenuItem onClick={ setPostFeatureImage }>
						{ __( 'Set as featured image' ) }
					</MenuItem>
				)
			}
		</BlockSettingsMenuControls>
	);

I'll make some changes locally and see if I can resolve this within the block code itself. I plan on making a PR shortly.

[t-hamano]

Related issue: #74742 (comment)