Gallery block: fix bug with link destination default option not being set#38310
Merged
glendaviesnz merged 2 commits intotrunkfrom Jan 31, 2022
Merged
Gallery block: fix bug with link destination default option not being set#38310glendaviesnz merged 2 commits intotrunkfrom
glendaviesnz merged 2 commits intotrunkfrom
Conversation
glendaviesnz
added
[Type] Bug
glendaviesnz
added
the
Backport to WP Minor Release
|
Size Change: +6 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jan 30, 2022
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
This is testing great for me @glendaviesnz, so I'm giving it the ✅! Thanks for fixing it up. I've just left a couple of optional notes for where we might be able to tighten up the code a little, but it's really just more a code style thing than anything that would impact performance, so it otherwise LGTM.
glendaviesnz
force-pushed
the
fix/gallery-default-linkto-bug
branch
from
dba4573 to
7cc692a
Compare
Mamaduka
removed
the
Backport to WP Minor Release
Mamaduka
pushed a commit
that referenced
this pull request
Feb 16, 2022
… set (#38310) Co-authored-by: Glen Davies <glen.davies@a8c.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #38302
With the refactored Gallery block the
image_default_link_typeoption is not being applied to new Images.Testing Instructions
/wp-admin/options.phpand setimage_default_link_typetofileMedia/wp-admin/options.phpand setimage_default_link_typetopostAttachment/wp-admin/options.phpand clear theimage_default_link_typesettingScreenshots
Before:
After:
