Try to fix infinite growing block previews#51485
Closed
kevin940726 wants to merge 1 commit intotrunkfrom
Closed
Conversation
kevin940726
added
[Type] Bug
|
Size Change: +135 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e7f551b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5265282955
|
Contributor
|
Nice, thanks for tackling this.
I would actually lean towards simply hard-cropping the pattern, and not showing any scrim or gradient. Keep it simple. |
Member
Author
That could look like a bug, but I don't think users gonna notice it 😆. @SaxonF WDYT? |
Member
|
Closing as stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
See #50449 (comment). It's still only a draft PR for demonstration. Hopefully, when it's ready, it can fix #50449 and #43865. Related to #38181 (comment).
Why?
The growing block previews experience is a weird UX 😅 .
How?
There are no perfect solutions. We can't force every block preview to render it's full content inside a iframe, because it might have a
120vhelement that keeps pushing the height of the iframe.Instead, what this PR is trying to do is to render a "more content" indicator for previews that still keep growing after loaded.
The actual design is TBD and should be changed though 😅 . This PR is just a naive approach.
Testing Instructions
Screenshots or screencast