Fix: Add version 3 migration for theme.json in post-featured-image block#69787
Closed
Sourav61 wants to merge 1 commit intoWordPress:trunkfrom
Closed
Fix: Add version 3 migration for theme.json in post-featured-image block#69787Sourav61 wants to merge 1 commit intoWordPress:trunkfrom
Sourav61 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Add version 3 migration for theme.json in post-featured-image block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #69769
This PR fixes the issue related to the migration handling for theme.json versions, specifically by adding support for version 3 of the theme.json configuration. The changes ensure that the block correctly handles the aspect ratio and height attributes during migration.
Why?
This PR is necessary because there is an issue with the migration process of theme.json versions 1 and 2 to version 3. Specifically, the migration logic was not handling version 3 correctly, leading to problems with setting the aspect ratio for blocks. This fix ensures that migration to version 3 works seamlessly.
How?
This PR addresses the issue by:
Testing Instructions