Skip to content

added filter for 'header_image()' function#2958

Closed
hz-tyfoon wants to merge 4 commits intoWordPress:trunkfrom
hz-tyfoon:filter-for-header-image
Closed

added filter for 'header_image()' function#2958
hz-tyfoon wants to merge 4 commits intoWordPress:trunkfrom
hz-tyfoon:filter-for-header-image

Conversation

@hz-tyfoon
Copy link
Copy Markdown

Trac ticket: 56180


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@hz-tyfoon
Copy link
Copy Markdown
Author

Just updated the PR.
removed the filter from header_image & added a filter in get_header_image.

Looks like it may make more sense to add the filter to get_header_image function as this way it'll work for both header_image & get_header_image (as inside header_image() there's only get_header_image() and then just printing the image url ).

Thanks @SergeyBiryukov for pointing this out.

@hz-tyfoon hz-tyfoon closed this Jul 12, 2022
@hz-tyfoon hz-tyfoon deleted the filter-for-header-image branch September 27, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants