Skip to content

Move MountDevice type declaration to @wp-playground/storage#3315

Merged
brandonpayton merged 2 commits intotrunkfrom
fix/move-type-decl-to-wp-playground-storage
Feb 28, 2026
Merged

Move MountDevice type declaration to @wp-playground/storage#3315
brandonpayton merged 2 commits intotrunkfrom
fix/move-type-decl-to-wp-playground-storage

Conversation

@zaerl
Copy link
Copy Markdown
Collaborator

@zaerl zaerl commented Feb 27, 2026

Motivation for the change, related issues

@wp-playground/storage depends on @php-wasm/web because of a single MountDevice type import in packages/playground/storage/src/lib/browser-fs.ts.

Implementation details

MountDevice type export is moved to @wp-playground/storage. @php-wasm/web continue exporting it for backwards compatibility.

Testing Instructions (or ideally a Blueprint)

Passing tests is enough.

Copilot AI review requested due to automatic review settings February 27, 2026 10:28
@zaerl zaerl self-assigned this Feb 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves the MountDevice type definition into @wp-playground/storage to remove an unnecessary dependency on @php-wasm/web, while keeping a deprecated MountDevice export in @php-wasm/web for compatibility.

Changes:

  • Update imports across packages to source MountDevice from @wp-playground/storage.
  • Define and export MountDevice in @wp-playground/storage (in browser-fs.ts).
  • Deprecate MountDevice in @php-wasm/web by aliasing it to the storage type.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
packages/playground/website/src/lib/state/redux/slice-clients.ts Switch MountDevice import to @wp-playground/storage.
packages/playground/storage/src/lib/browser-fs.ts Introduce exported MountDevice type in storage.
packages/playground/remote/src/lib/playground-worker-endpoint.ts Switch MountDevice import to @wp-playground/storage.
packages/playground/personal-wp/src/lib/state/redux/slice-clients.ts Switch MountDevice import to @wp-playground/storage.
packages/php-wasm/web/src/lib/directory-handle-mount.ts Deprecate MountDevice export by aliasing storage’s type.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@brandonpayton brandonpayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @zaerl!

@brandonpayton brandonpayton merged commit 9aed107 into trunk Feb 28, 2026
42 checks passed
@brandonpayton brandonpayton deleted the fix/move-type-decl-to-wp-playground-storage branch February 28, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants