Move MountDevice type declaration to @wp-playground/storage#3315
Merged
brandonpayton merged 2 commits intotrunkfrom Feb 28, 2026
Merged
Move MountDevice type declaration to @wp-playground/storage#3315brandonpayton merged 2 commits intotrunkfrom
brandonpayton merged 2 commits intotrunkfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the MountDevice type definition into @wp-playground/storage to remove an unnecessary dependency on @php-wasm/web, while keeping a deprecated MountDevice export in @php-wasm/web for compatibility.
Changes:
- Update imports across packages to source
MountDevicefrom@wp-playground/storage. - Define and export
MountDevicein@wp-playground/storage(inbrowser-fs.ts). - Deprecate
MountDevicein@php-wasm/webby aliasing it to the storage type.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/playground/website/src/lib/state/redux/slice-clients.ts | Switch MountDevice import to @wp-playground/storage. |
| packages/playground/storage/src/lib/browser-fs.ts | Introduce exported MountDevice type in storage. |
| packages/playground/remote/src/lib/playground-worker-endpoint.ts | Switch MountDevice import to @wp-playground/storage. |
| packages/playground/personal-wp/src/lib/state/redux/slice-clients.ts | Switch MountDevice import to @wp-playground/storage. |
| packages/php-wasm/web/src/lib/directory-handle-mount.ts | Deprecate MountDevice export by aliasing storage’s type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
@wp-playground/storagedepends on@php-wasm/webbecause of a singleMountDevicetype import in packages/playground/storage/src/lib/browser-fs.ts.Implementation details
MountDevicetype export is moved to@wp-playground/storage.@php-wasm/webcontinue exporting it for backwards compatibility.Testing Instructions (or ideally a Blueprint)
Passing tests is enough.