Run [article_title] shortcode through do_shortcode().#63
Open
mindctrl wants to merge 1 commit intoWordPress:trunkfrom
Open
Run [article_title] shortcode through do_shortcode().#63mindctrl wants to merge 1 commit intoWordPress:trunkfrom
[article_title] shortcode through do_shortcode().#63mindctrl wants to merge 1 commit intoWordPress:trunkfrom
Conversation
This needs to happen because it's all passed through `sprintf`, which causes the literal text to be printed instead of the shortcode output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs to happen because it's all passed through
sprintf, which causes the literal text to be printed instead of the shortcode output. You can see this by inspecting the footer area where the article title is supposed to render with an edit link.The broken link is a separate matter, which comes down to meta key value. See WordPress/hosting-handbook#340 (comment). Question is: update the theme or fix the meta key names in wp-admin?
Edit: I'm not sure this shortcode is registered anywhere. I don't see it in the theme, and the only other place I found it to be registered is in the 2023 developer theme here: https://github.com/WordPress/wporg-developer/blob/af552d561ba3e61d913e16ae9184de1d6aeb8a1e/source/wp-content/themes/wporg-developer-2023/inc/shortcodes.php#L64