Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the GitHub Action from Node 20 to Node 24, ensuring compatibility with the latest Node.js features and improvements. The upgrade includes updating the Node.js engine requirements, TypeScript definitions, and GitHub Actions runtime configuration.
- Updates Node.js engine requirement from >=20.0.0 to >=24.0.0
- Updates @types/node from 24.0.12 to 24.1.0
- Changes GitHub Action runtime from node20 to node24
- Normalizes quote style in license files from double quotes to single quotes
Reviewed Changes
Copilot reviewed 26 out of 29 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates Node.js engine requirement and @types/node version |
| action.yml | Changes GitHub Action runtime from node20 to node24 |
| .licenses/*.dep.yml | Normalizes quote style in license metadata files |
| .github/workflows/post-dependabot.yml | Removes empty line in workflow file |
Contributor
|
Hi @salmanmkc thanks for putting this together and sorry we missed it. Can I help move this along at all? Or happy to approve if you can get the conflicts resolved. I wonder if we need this upgrade to get #723 working as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the project to utilize Node 24, since runner now supports node24. https://github.com/actions/runner/releases/tag/v2.327.1