Skip to content

clean code + fix dropdown#183

Open
SylvainLegrand wants to merge 22 commits intoaspangaro:2024_rcfrom
SylvainLegrand:2024_rc
Open

clean code + fix dropdown#183
SylvainLegrand wants to merge 22 commits intoaspangaro:2024_rcfrom
SylvainLegrand:2024_rc

Conversation

@SylvainLegrand
Copy link
Copy Markdown
Collaborator

No description provided.

New option for info boxes => authorize adaptive width according to content or use Dolibarr mode (fix width)

Fix missing english translations
Add hidden options for CKEditor
add a process for implementing new fonts:
1 - new font.css => font-face for added fonts
2 - change of config.js to take into account the new fonts in the WYSYWIG editor
3 - added 2 fonts => Puente and Neuropol
fix dropdown
Copilot AI review requested due to automatic review settings October 1, 2025 15:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR focuses on code cleanup and fixing dropdown functionality within the Oblyon theme. The main changes include standardizing PHP output syntax and reorganizing CSS structure.

  • Standardizes PHP output by replacing echo with print throughout the codebase
  • Converts hardcoded color values to CSS custom properties (variables) for better maintainability
  • Removes duplicated CSS declarations in the login block section

Reviewed Changes

Copilot reviewed 8 out of 41 changed files in this pull request and generated no comments.

Show a summary per file
File Description
themeoblyon/style.css.php Fixes variable name casing for $colorstitle
themeoblyon/login.inc.php Converts hardcoded colors to CSS variables and removes extensive duplicated CSS
themeoblyon/global.inc.php Standardizes echo to print and adds missing CSS variable definitions
themeoblyon/dropdown.inc.php Converts hardcoded colors to CSS variables
themeoblyon/btn.inc.php Expands button selector to include additional UI elements
sql/data.sql Removes empty line for cleaner formatting
langs/fr_FR/oblyon.lang Adds CKEditor configuration translation strings
langs/en_US/oblyon.lang Adds CKEditor configuration translation strings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants