Compatibility with multicompany and v22#191
Conversation
Multicompany : dropdown on inverted menu V22 : new button create + dropdowon on fixed action bar Use of HTML var
|
Peux-tu vérifier s'il te plait ? |
There was a problem hiding this comment.
Pull request overview
This PR updates the Oblyon theme/menu to better support multicompany UI needs and Dolibarr v22 UI changes (notably sticky action bar dropdown behavior), while moving more styling to CSS variables.
Changes:
- Add multicompany-aware sizing for the login/topbar area and adjust login bar behavior for inverted menus.
- Introduce/expand CSS custom properties (
var(--...)) and update multiple theme styles to consume them. - Update Oblyon menu manager to use
GETPOST*helpers and add aleftdropdownrender mode; adjust hook result handling for v22.
Reviewed changes
Copilot reviewed 8 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| themeoblyon/style.css.php | Increases login block max width when multicompany is enabled. |
| themeoblyon/login.inc.php | Reworks login top bar styling, adds sticky/inverted handling, switches to CSS variables. |
| themeoblyon/info-box.inc.php | Makes infobox background configurable with a fallback to white. |
| themeoblyon/global.inc.php | Adds new CSS variables, converts many computed colors to var(...), tweaks sticky action bar dropdown z-index/positioning. |
| themeoblyon/fonts/oblyon-icons.woff | Adds/updates icon font asset for the theme. |
| themeoblyon/fonts/oblyon-icons.ttf | Adds/updates icon font asset for the theme. |
| themeoblyon/fonts/oblyon-icons.eot | Adds/updates icon font asset for the theme. |
| themeoblyon/dropdown.inc.php | Aligns dropdown styling with CSS variables and adds --up/--left dropdown variants for v22 behavior. |
| core/menus/standard/oblyon_menu.php | Replaces direct $_GET access with GETPOST* and adds leftdropdown mode. |
| core/menus/standard/oblyon.lib.php | Updates multicompany condition checks and switches hook results to resArray for v22. |
| config.php | Minor formatting change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| input.buttonpaymentcheque { | ||
| background-image: url(<?php echo dol_buildpath($path.'/paypal/img/object_paypal.png',1) ?>); | ||
| background-image: url(<?php print dol_buildpath($path.'/paypal/img/object_paypal.png',1) ?>); | ||
| background-repeat: no-repeat; | ||
| background-position: 5px 4px; |
There was a problem hiding this comment.
input.buttonpaymentcheque is defined twice, and the second rule sets a PayPal icon. Because it comes later, it overrides the cheque icon, so the cheque payment button will display the PayPal image. Consider changing the second selector to the correct payment method (likely input.buttonpaymentpaypal) or removing the duplicate rule to avoid overriding the cheque styling.
| div.login_block_other { | ||
| display: inline-block; | ||
| clear: <?php print $disableimages ? 'none' : 'both'; ?>; | ||
| } |
There was a problem hiding this comment.
div.login_block_other is declared twice (once earlier with several layout properties and again later with only display/clear). This duplication makes the final applied styles harder to reason about and is easy to accidentally diverge. Consider merging these into a single rule or removing the redundant block.
| div.login_block_other { | |
| display: inline-block; | |
| clear: <?php print $disableimages ? 'none' : 'both'; ?>; | |
| } |
Multicompany : dropdown on inverted menu
V22 : new button create + dropdowon on fixed action bar Use of HTML var