Skip to content

chore: drop nodemon#2992

Merged
ajhollid merged 2 commits intobluewave-labs:developfrom
AlexHladin:chore/drop-nodemon
Oct 18, 2025
Merged

chore: drop nodemon#2992
ajhollid merged 2 commits intobluewave-labs:developfrom
AlexHladin:chore/drop-nodemon

Conversation

@AlexHladin
Copy link

@AlexHladin AlexHladin commented Oct 1, 2025

Describe your changes

This PR removes nodemon from server dependencies. Since Node.js 18, it supports file watching via the --watch flag.

Please ensure all items are checked off before requesting a review. "Checked off" means you need to add an "x" character between brackets so they turn into checkmarks.

  • (Do not skip this or your PR will be closed) I deployed the application locally.
  • (Do not skip this or your PR will be closed) I have performed a self-review and testing of my code.
  • I have included the issue # in the PR.
  • I have added i18n support to visible strings (instead of <div>Add</div>, use):
const { t } = useTranslation();
<div>{t('add')}</div>
  • I have not included any files that are not related to my pull request, including package-lock and package-json if dependencies have not changed
  • I didn't use any hardcoded values (otherwise it will not scale, and will make it difficult to maintain consistency across the application).
  • I made sure font sizes, color choices etc are all referenced from the theme. I don't have any hardcoded dimensions.
  • My PR is granular and targeted to one specific feature.
  • I ran npm run format in server and client directories, which automatically formats your code.
  • I took a screenshot or a video and attached to this PR if there is a UI change.

Summary by CodeRabbit

  • Chores
    • Updated development and start scripts to use native tooling and watch mode for more stable, faster restarts during development.
    • Declared a minimum Node version requirement (>= 20).
    • Removed an unnecessary dependency to simplify setup and slightly reduce install size.
    • No user-facing behavior changes.

@coderabbitai
Copy link

coderabbitai bot commented Oct 1, 2025

Walkthrough

Updated server/package.json: replaced nodemon-based dev/start scripts with tsx watch and node --watch, removed nodemon from dependencies and devDependencies, and added engines.node: ">=20".

Changes

Cohort / File(s) Summary of Changes
Server package metadata
server/package.json
- Scripts updated: dev changed from "nodemon --exec tsx src/index.js" to "tsx watch src/index.js"; start changed from "nodemon ./dist/index.js" to "node --watch ./dist/index.js"
- Removed dependencies.nodemon: "3.1.9"
- Removed devDependencies.nodemon: "3.1.9"
- Added engines: { "node": ">=20" }

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop through scripts with gentle cheer,
Nodemon’s burrow now less near.
TSX keeps watch, Node hums along—
My startup song is short and strong. 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description includes a clear explanation of the changes and a checklist, but it omits the required “Fixes #” section specified by the repository template and therefore does not fully comply with the template requirements. Please add a “Fixes #” section immediately after the description heading to reference the related issue and ensure compliance with the repository’s pull request template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title ‘chore: drop nodemon’ accurately and concisely summarizes the primary change of removing nodemon from the server, reflecting the main change set without unnecessary detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b22ce7 and 8bf3875.

📒 Files selected for processing (1)
  • server/package.json (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • server/package.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@llamapreview llamapreview bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto Pull Request Review from LlamaPReview

Review Status: Automated Review Skipped

Dear contributor,

Thank you for your Pull Request. LlamaPReview has analyzed your changes and determined that this PR does not require an automated code review.

Analysis Result:

PR contains only dependency removal and script updates, requiring no automated code review

We're continuously improving our PR analysis capabilities. Have thoughts on when and how LlamaPReview should perform automated reviews? Share your insights in our GitHub Discussions.

Best regards,
LlamaPReview Team

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5dbfb3b and 3b22ce7.

⛔ Files ignored due to path filters (1)
  • server/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • server/package.json (1 hunks)

Comment on lines +9 to +10
"dev": "tsx watch src/index.js",
"start": "node --watch ./dist/index.js",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Ensure runtime is on Node ≥18.11 before relying on --watch.

Switching start to node --watch ./dist/index.js (and dropping nodemon) will abort immediately on any environment still running Node 18.0–18.10, because the flag was only added in v18.11 and remained experimental in the 18.x line. Previous builds worked on all 18.x because nodemon handled restarts externally. Please either document and enforce a minimum Node of ≥18.11 (ideally ≥20.13 where watch mode is stable) or keep a backward‑compatible fallback. (nodejs.org)

🤖 Prompt for AI Agents
In server/package.json around lines 9-10, the new "start" script uses the Node
CLI --watch flag which is only available from Node v18.11+ (and more stable in
v20.13+), so running on Node 18.0–18.10 will immediately fail; fix by either
enforcing a minimum Node engine version and documenting it (add an "engines"
field specifying "node": ">=18.11" or preferably ">=20.13" and update README/CI
to validate it) or provide a backward-compatible start script (detect Node
version at runtime or in npm scripts and fall back to nodemon or plain node when
<18.11). Ensure package.json and project docs/CI reflect the chosen minimum Node
version so installs on older runtimes fail fast with a clear message.

"author": "",
"license": "ISC",
"engines": {
"node": ">=20"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to production Dockerfile

Copy link
Collaborator

@ajhollid ajhollid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your contribution!

@ajhollid ajhollid merged commit 3a8ba15 into bluewave-labs:develop Oct 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants